Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsconfig: stop emitting files #7425

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pjonsson
Copy link
Contributor

What this PR does

Running tsc with --diagnostics
with an empty dist/ shows that
emitting takes nearly 2 seconds
on a fast SSD:

I/O write: 0.12s
Emit time: 1.75s

Since nothing seems to use
the emitted files, disable
emitting files to save that
time.

Test me

See that the CI tests still pass for this PR, and then empty dist/ and run yarn run tsc -b tsconfig-node.json --diagnostics before/after the commit.

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

Running tsc with --diagnostics
with an empty dist/ shows that
emitting takes nearly 2 seconds
on a fast SSD:

I/O write: 0.12s
Emit time: 1.75s

Since nothing seems to use
the emitted files, disable
emitting files to save that
time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant